Welcome to the AFK Mods bug tracker. In order to report an issue, please select a project from the drop down menu below. Select “Open New Issue” and fill out the form with as many details as possible.

An account will be required to submit an issue, so if you need one and are unable to register, please contact us via the forums at https://afkmods.iguanadons.net/
       

Issue Data
Status: Fix Pending
Issue Type: Bug Report
Project: Unofficial Fallout 4 Patch
Component: Fallout 4: Vanilla
Category: Papyrus
Assigned To: Sclerocephalus
Platform: All
Severity: Very Low
Votes: 0
Watching: N/A
Opened By Sclerocephalus on Dec 3, 2017 9:12 am

Issue #23253: CIS_ManagerScript sends dozens of unnecessary story events

Every time this script runs, it sends 17 story events in a row, but it should actually send only one. This is because it does not properly check for the current follower in its tryToChatWithNPCs function (lines 122-138):

function tryToChatWithNPCs(Actor myCompanion, Faction factionToCheck, objectreference myTarget, location myLocation, bool isRacialComment = false)

Actor myTargetActor = myTarget as Actor

if myTargetActor && myTargetActor.IsInfaction(factionToCheck) && myCompanion == myCompanion

if isRacialComment == false
FollowersScript.StartCompanionInteractionScene(CIS_Type_ChatWithNPC, myTarget, myLocation, myCompanion)

else ;is racial comment
FollowersScript.StartCompanionInteractionScene(CIS_Type_RacialComments, myTarget, myLocation, myCompanion)

endif
endif


EndFunction

Checking for 'myCompanion == myCompanion' is always true, so this function always sends an event, in all 17 instances it is called by the StartCompanionInteractionScene function on the same script. Instead it should check whether myCompanion is equal to the current companion.