Welcome to the AFK Mods bug tracker. In order to report an issue, please select a project from the drop down menu below. Select “Open New Issue” and fill out the form with as many details as possible.

An account will be required to submit an issue, so if you need one and are unable to register, please contact us via the forums at https://afkmods.iguanadons.net/

Issue Data
Status: Closed
Issue Type: Bug Report
Project: Unofficial Fallout 4 Patch
Component: Fallout 4: Vanilla
Category: Papyrus
Assigned To: Sclerocephalus
Platform: All
Severity: Low
Votes: 0
Watching: N/A
Opened By Sadishist on Oct 7, 2018 1:14 pm
Last Edited By Sclerocephalus on Nov 1, 2018 2:02 pm
Closed By Sclerocephalus on Dec 3, 2018 1:03 am
Resolution: Fixed
Comment: Fixed for UFO4P 2.0.6

Issue #25243: "Repair a damaged object" message spam if Mechanist Lair is taken before other settlements establish

Say you start a new game, clear the bloatflies with Codsworth, and unlock Sanctuary as a settlement, but don't advance the "Out of Time" quest and don't recruit any settlers for Sanctuary or any other settlements (you can go ahead and unlock settlements, you just can't have any settlers). You head straight to caravan and proceed through Automatron questline, eventually building Jezebel at any workshop you unlocked but not having any other settlers anywhere. You keep doing the questline and then eventually you finish Automatron and unlock Mechanist Lair. You will keep getting the message spam "Repair a damaged object" whenever you enter the workshop menu in Mechanist Lair or any other workshop you unlocked, even after you repair that small generator in Mechanist Lair and there is nothing else that needs repairing in any settlement. (Note to mention: I moved Jezebel to Mechanist Lair right after I unlocked it).

What I'm guessing for this bug is that it's a tutorial text issue, that the process somehow gets scrambled if you get Mechanist Lair while never having any human settlers either due to the small generator there that always gets broken during your confrontation with Mechanist, or due to inheriting a settlement with a defense rating? Once I built a turret at Sanctuary the message finally goes away, there was absolutely no settlement items that was damaged.

Hope I was clear enough.

Related Issues: 20294  


2 comment(s) [Closed]
Sclerocephalus said:
This had nothing to do with skipping the "Out of Time" quest and is also not related to specific workshops. It can affect any workshop at any time as long as this tutorial is not completed. There was an inappropriate condition check on WorkshopTutorialScript that could result in the tutorial being started for objects which the player cannot repair. There are plenty of objects that can be damaged but not repaired by the player - beds for example ! Why they can be damaged at all is another question but it definitely happens (clear evidence from the workshop logs). Some of these (e.g. beds) do not even change their visual appearance if they are getting damaged.

Once this happens, the tutorial never stops running until you leave the workshop and start doing stuff at another workshop that results in a workshop event being sent (in your case, building the turret at Sanctuary resulted in an "OnWorkshopObjectBuilt" event being sent by the Sanctuary workshop). WorkshopTutorialScript reacts to any and all workshop events and uses them to detect whether the player left a workshop while a tutorial was running, and if so, rolls back that tutorial (i.e.iit stops processing it and flags it as never started). In your case, the "damaged object turorial" was running on the Mechanist's Lair, and when you did build the turret at Sanctuary and the event was sent, WorkshopTutorialScript noticed that you were no longer at the Mechanist's Lair and stopped the tutorial.

Which means that it will start running again whenever an object gets damaged while you stay at a workshop, and this only stops if you successfully complete it (i.e. if the tutorial finally starts running on an object which you can repair and you repair it).

Fixed the condition check, so the tutrorial will not start running again on objects which the player can't repair. Also added a check to evaluate the damaged object if the tutorial is currently running and to roll it back immediately if that object is invalid.

Comment #1 Nov 1, 2018 1:53 pm  Edited by Sclerocephalus on Nov 1, 2018 1:54 pm
Sadishist said:
Thanks, great work!

Showing Comments 1 - 2 of 2